Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDF imports already accept a
%PDF-marker within the first 1,024 bytes, but browser downloads require it at byte zero. This rejects otherwise importable PDFs with a leading BOM or padding. The existing ASCII conversion also masks high bits and can mistake non-ASCII bytes for the marker.Retain at most 1,024 prefix bytes and search for the exact marker, matching the import check. Generated-PDF tests verify BOM/padding, a marker split across stream chunks, the exact window boundary, byte-preserving publication, and rejection/cleanup of late markers and high-bit lookalikes.
Validation: both regressions failed before the fix; PDF tests 9/9; full unit suite 486 passed, 3 platform-dependent skips, 0 failed. Repository lint, server/mobile/worker typechecks and server build pass. Independent review found no actionable issues.
Windows Chromium limitation: the profile cleanup/reopen test passes on rerun. The worker-process restart test fails because SIGTERM yields a null exit code where the fixture expects zero; the same failure was reproduced using the unmodified upstream worker. The initial run also encountered an EBUSY profile-cleanup error, which did not recur on baseline or rerun. Linux Chromium/container CI remains the integration check.