Skip to content

fix: resolve Ruff formatting failures in enterprise observability - #29

Merged
CoreyLeath-code merged 9 commits into
mainfrom
feat/enterprise-observability
Sep 4, 2026
Merged

CoreyLeath-code merged 9 commits into
mainfrom
feat/enterprise-observability

Conversation

@CoreyLeath-code

@CoreyLeath-code CoreyLeath-code commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Fixes the CI quality failure shown in the latest PR #28 run.

The failing Ruff 0.16 formatter identified exactly three files:

  • logsight/enterprise.py
  • logsight/storage.py
  • tests/test_enterprise.py

These commits now match the formatter output reported by GitHub Actions. No CI result is being assumed until GitHub runs this PR.

Summary by CodeRabbit

  • Style
    • Reformatted internal expressions for improved code readability without changing functionality or behavior.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 34d6c57e-9459-4aa0-b964-f22136a16862

📥 Commits

Reviewing files that changed from the base of the PR and between 729bb32 and c78989f.

📒 Files selected for processing (1)
  • logsight/storage.py

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: ce9b92ef-6fac-4461-bc5b-fab8c4d8c1a4

📥 Commits

Reviewing files that changed from the base of the PR and between d7d98ae and 729bb32.

📒 Files selected for processing (1)
  • logsight/enterprise.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR reformats two generator expressions in score_event from multi-line to single-line form. The operands, logic, and computation remain unchanged.

Changes

score_event formatting

Layer / File(s) Summary
Format score expressions
logsight/enterprise.py
The same and error_rate generator expressions use single-line formatting. Their behavior is unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 729bb

This change only applies formatter-compatible layout to the score calculation without changing behavior. No current merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing Ruff formatting failures in the enterprise observability code. It is concise and specific.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/enterprise-observability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CoreyLeath-code
CoreyLeath-code merged commit 5e93ff6 into main Sep 4, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant