Skip to content

fix: resolve CI mypy failures after enterprise observability merge - #31

Merged
CoreyLeath-code merged 3 commits into
mainfrom
fix/ci-mypy-enterprise
Sep 4, 2026
Merged

CoreyLeath-code merged 3 commits into
mainfrom
fix/ci-mypy-enterprise

Conversation

@CoreyLeath-code

Copy link
Copy Markdown
Owner

Summary

  • keep Ruff formatting/checks clean
  • configure mypy for optional integration modules that are intentionally dependency-light
  • disable stale-ignore warnings for optional-import fallbacks
  • add explicit casts for HTTP/JSON return values
  • make webhook status comparison explicitly boolean

Root cause

The post-merge CI run passed Ruff and security checks but failed strict mypy with 13 errors across the optional FastAPI, Kafka, OpenTelemetry, storage, and enterprise integrations.

This patch addresses those exact failures without making the optional integrations mandatory runtime dependencies.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: b8ceeb3d-4417-4fb2-b02a-8f89e8586550

📥 Commits

Reviewing files that changed from the base of the PR and between 4f339d9 and 049a143.

📒 Files selected for processing (3)
  • logsight/enterprise.py
  • logsight/storage.py
  • pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CoreyLeath-code
CoreyLeath-code merged commit 6f446a0 into main Sep 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant