Skip to content

COR-1493: CLI fetches scan issues by project_name instead of scan_id,…#117

Open
Ibrahimrahhal wants to merge 1 commit into
mainfrom
COR-1493
Open

COR-1493: CLI fetches scan issues by project_name instead of scan_id,…#117
Ibrahimrahhal wants to merge 1 commit into
mainfrom
COR-1493

Conversation

@Ibrahimrahhal

Copy link
Copy Markdown
Member

… causing false "Project not found" errors

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No actionable findings found.

Verified the PR diff against main for src/inspect.rs, src/scanners/blast.rs, and src/wait.rs. The changed call chain now passes the resolved scan id into report_scan_status / fetch_and_group_scan_issues, which reaches the existing get_all_issues(..., Some(scan_id)) path and uses the pre-existing /api/v1/scan/{scan_id}/issues endpoint already exposed by list --issues --scan-id. I also checked the related command call sites, API response handling, and test tree; there are no existing API mock tests for this SAST issue aggregation path, but I did not find a concrete regression from this diff.

Validation run: RUSTUP_TOOLCHAIN=stable ./harness test passed with 211 passed. git diff --check also passed.

Open in Web View Automation 

Sent by Cursor Automation: pr-flow

@yhoztak yhoztak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juangaitanv juangaitanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants