Fix dashboard dependency policy and CI review findings - #19
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe dashboard dependency policy now limits TypeScript and Node type updates. Two workflows disable persisted checkout credentials. The build checker accepts a supplied build directory and verifies the expected footprint layer IDs, with tests for manifest contents and required assets. ChangesDashboard dependency constraints
Dashboard build validation
Workflow checkout credentials
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Merge Risk: ⚪ Minimal · up to The dependency range matches the lockfile, and no actionable merge-blocking issue is established in the reviewed changes. The PR is mergeable subject to normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependabot PR #18 upgrades TypeScript to 7.0.2, but typescript-eslint 8.71.0 requires
>=4.8.4 <6.1.0, so its CI fails duringnpm ciwith ERESOLVE. It also advances Node types to version 26 while the runtime remains Node 24. This keeps automatic updates within the supported compiler/runtime ranges and applies the verified CodeRabbit findings from #17.Validation: lint without warnings, type checking, five Node regression tests, Python exporter test, production build with 31,569 objects, isolated clean-install/fixture build, artifact checks and Actionlint.
PR #18 should not be merged as currently proposed. These policy changes prevent equivalent future proposals after this PR is merged; they do not retroactively change the existing Dependabot PR. The previous deployment on main completed successfully.
Summary by CodeRabbit