Repository navigation
Image sims: epoch-membership bounds for the trimmed 2048x4612 CCDs - #957
Open
cailmdaley wants to merge 2 commits into
Open
cailmdaley wants to merge 2 commits into
cailmdaley wants to merge 2 commits into
Conversation
The sims inherited the MegaCam DATASEC bounds (33,2080) of untrimmed 2112-px CCDs. On the 2048-px sim CCDs, objects at 2048<x<2080 gained an epoch on pixels that do not exist (get_stamps raises: 'Stamp centre(s) fall outside the image'), and objects at x<33 lost a real one. input_types.image_sims.ccd_size reaches config_tile_Sx.ini as SP_CCD_SIZE; data keeps the ini default, so data params are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # astra.yaml
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image simulations inherit the real-data epoch-membership bounds
CCD_SIZE = 33,2080,1,4612, the MegaCam DATASEC of an untrimmed 2112×4644 CCD. The SKiLLS CCDs are trimmed to 2048×4612 with no overscan, so:get_stamps, ca2a76f) landed,tile_vignetsraisesStamp centre(s) fall outside the image (shape (4612, 2048)), and every image-sim tile fails.The sim WCS is in the trimmed frame. Bright tile objects mapped into a sim exposure land on their light to 0.00 px (median over 1,588 objects, exposure 2086771, tile 233.293). The fix is therefore the bounds alone, not the WCS.
Change.
input_types.image_sims.ccd_size: 0,2047,0,4611reachesconfig_tile_Sx.iniasSP_CCD_SIZEthroughtile_detect's prologue, for image sims only. The ini keeps the data value as its default (${SP_CCD_SIZE:-33,2080,1,4612}), so data params, and with them data reruns, are unchanged. The legacyexample/cfis_image_sims/config_tile_Sx.inigets the same bounds.astra.yaml'sdetection.epoch_membership_ccd_boundsrecords both values.Earlier sims m measurements ran with the data bounds. Their edge objects had padded off-image stamps and lost epochs at x < 33. The size of that effect on m is unmeasured.
Found while setting up the defect/blend A/B on the blended SKiLLS sims.
🤖 Generated with Claude Code