Skip to content

Add ActionResult::yield() and ExecutionState::YIELD - #60

Merged
benrowe merged 20 commits into
masterfrom
claude/github-issue-57-9xphmy
Jul 1, 2026
Merged

Add ActionResult::yield() and ExecutionState::YIELD#60
benrowe merged 20 commits into
masterfrom
claude/github-issue-57-9xphmy

Conversation

@benrowe

@benrowe benrowe commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

benrowe commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Re the @phpstan-impure comment on ActionExecutionService::executeAction(): removed in the latest commit. The annotation was working around a PHPStan false positive where it cached isYielded() as always-false after a call it treated as pure. Replaced structurally — executeNextAction() now captures the ExecutionState return value from executeAction() and checks it via a new ExecutionState::isYield() helper (consistent with GateResult::shouldSkipAction() / shouldStopTransition()), so the context is never re-queried after the call.


Generated by Claude Code

Comment thread src/Action/ActionExecutionService.php Outdated
claude added 20 commits July 1, 2026 03:27
@benrowe
benrowe force-pushed the claude/github-issue-57-9xphmy branch from 75a45ac to 0167692 Compare July 1, 2026 03:27
@benrowe
benrowe merged commit fbec177 into master Jul 1, 2026
8 checks passed
@benrowe
benrowe deleted the claude/github-issue-57-9xphmy branch July 1, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants