Repository navigation
ci: pin workflow actions to commits rather than tags - #12
Merged
Merged
Conversation
actions/checkout@v4 and shivammathur/setup-php@v2 are moving references. Whoever controls those repositories can point them at different code without the tag changing, and this package is the signing contract two other packages resolve against - so the job deciding whether a change to it is sound is a job worth knowing the contents of. platform and manager-restore already pin these same two commits. This brings the last one into line. The run reaches little - contents: read, no secrets beyond GITHUB_TOKEN, no pull_request_target, nothing published - which bounds the exposure rather than excusing it. No wire change: no schema, canonical string, signature or fixture moved, and the committed signing fixtures still verify. Version moves because 1.8.0 is tagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/checkout@v4andshivammathur/setup-php@v2are moving references. Whoever controls thoserepositories can point them at different code without the tag changing.
This package is the signing contract that
platform,connectorandrestoreall resolve against, sothe job deciding whether a change to it is sound is a job worth knowing the contents of.
platformandmanager-restorealready pin these same two commits; this brings the last one into line.Bounded, not urgent. The run reaches very little —
permissions: contents: read, no secrets beyondGITHUB_TOKEN, nopull_request_target, nothing published. That bounds the exposure rather thanexcusing the moving reference.
No wire change. No schema, canonical string, signature or fixture moved, so this is interchangeable
with 1.8.0 on either side of the protocol.
./vendor/bin/pest391 passed — including the committedsigning fixtures, which are the change detector for exactly that, and
VersionTest, which is whatenforces that
composer.jsonandProtocol::VERSIONstate one version rather than two.The version moves because 1.8.0 is tagged, so the number
maindeclares stays one somebody could tagtoday. Patch.