Repository navigation
fix: say which site the activity log is filtered to, and keep it through Apply - #107
Merged
Merged
Conversation
…ugh Apply A site's Audit page links to the fleet log with ?site= set, and the log filtered to that site without saying so. The filter form carried only the outcome select, so pressing Apply dropped the site and widened the log to every site. The form now has a Site select beside the outcome one, set to the site in the query string, and a note reading "Showing activity for <site>" while a site filter is active. Options come from the organisation's own sites, so another tenant's site is never offered. A site address that matches none of them says so instead of presenting an empty log as though nothing had happened. CHANGELOG gains 1.8.2; docs/getting-started.md and docs/upgrade.md move to 1.8.2 and docs/rollback.md to 1.8.1, as DocumentedVersionTest expects.
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Open in the fleet log link on a site's Audit page opens the Activity log with the site in the query string, and the log was filtered to that site without saying so. The filter form only carried the outcome select, so pressing Apply dropped the site and widened the log back to every site.
What changed:
Patch release 1.8.2: CHANGELOG entry and the worked version examples in
docs/getting-started.md,docs/upgrade.mdanddocs/rollback.mdare in the same commit. No CSS change, sopublic/buildis unchanged (rebuilt and confirmed identical).Verified in a clean clone against a dedicated test database:
tests/Feature/WebInterfaceTest.php: 27 passed, including four new cases (site preselected, tenant isolation and unknown address, outcome filter keeps the site, filtering to one site).