Repository navigation
feat: show the Node.js version a site's project files declare - #111
Merged
Merged
Conversation
A site's .nvmrc, .node-version or package.json engines.node says which Node.js it needs, and nothing in Manager showed it. The runtime ingest now accepts system.v4, which carries it, and advertises it first so a connector that implements it starts sending it. The overview and Health screens show it as "Node.js (declared)" with the file it came from, and say underneath that it is what the project asks for rather than what is installed - the connector reads a file and runs nothing. Three states are kept apart: a version, "Not declared" (the connector looked and found nothing) and "Not reported - connector update needed" (a connector older than system.v4). No row at all for a site that has sent no runtime report. The value stays in the report's payload; no migration. Needs manager-protocol 1.10, so composer.json now requires it and composer.lock moves when that is tagged. Until then the tests that validate a v4 payload are skipped with the reason rather than failing.
# Conflicts: # CHANGELOG.md # docs/rollback.md
system.v4 ships inside the package, and this branch requires ^1.10. The lockfile moves from 1.9.0 to 1.10.0, which is the only change to it. The v4 payload tests that skip while the schema is absent now run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
coysh-digital/manager-protocol1.10.0, which is now published;composer.lockresolves it.What
A site's
.nvmrc,.node-versionorpackage.json(engines.node) says which Node.js it needs, and nothing in Manager showed it. The runtime ingest now acceptssystem.v4, which carries it, and advertises it first so a connector that implements it starts sending it.system.v1tosystem.v3are still accepted.20.11.0 (.nvmrc).system.v4). A site with no runtime report at all gets no row, so a connector that is simply not allowed to report is not told to update.runtime_reports.payload; no migration. Output is escaped (tested).docs/security.md,docs/monitoring.md,docs/capabilities.md,docs/craft-plugin.md, and a 1.9.0 changelog heading with the version examples ingetting-started,upgradeandrollback.The dependency
composer.jsonrequirescoysh-digital/manager-protocol^1.10, because advertisingsystem.v4against an older package would make the validator fail on the first v4 report.composer.locknow resolves 1.10.0, the published release; that is the only change to the lockfile.schemas/system.v4.json. With 1.10.0 installed they all run.Verification
In a clean clone with 1.10.0 from Packagist, on this branch brought up to date with main:
npm run buildrebuilds the committed stylesheet to itself, sopublic/buildis unchanged.The matching connector change is in 1.16.0 of the connector.