Repository navigation
merge(rust): start the Python fallback as python3 on Windows - #3
Merged
Merged
Conversation
The binary hands an event to run_hook.py when it does not model it, and on any error or panic. On Windows it started `python`, while the hook rows and the README require a real `python3`: on a machine where `python` is missing or only the Microsoft Store stub, every hand-over failed. Every Python row of hooks.json, SessionStart's install among them, already starts `python3`, so a machine the plugin runs on has one. CI is unaffected: the Windows build row only runs cargo test and build, and install_smoke already puts a python3.exe on PATH. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust binary hands an event to
run_hook.pywhen it does not model it, and on any error or panic. On Windows it startedpython, while the hook rows and the README require a realpython3. On a machine wherepythonis missing or is only the Microsoft Store stub, every hand-over failed.Every Python row of
hooks.json, SessionStart's install among them, already startspython3, so any machine the plugin runs on has one.platform::python_fornow returnspython3on both OS families, and its unit test checks that.CI is unaffected: the Windows build row only runs
cargo testandcargo build, andinstall_smokealready puts apython3.exeon PATH.Checked locally:
cargo test(6 passed),cargo check --target x86_64-pc-windows-msvc, and the install_binary, budget, handback and build_manifest selftests.This lands before the live Windows session, which the reminder
murmuration-win-liveholds for 2026-11-02.🤖 Generated with Claude Code