feat(config): add install.disk to MachineConfig#17
Merged
Conversation
Add an Install message with a disk field to MachineConfig so the maintenance install flow can name the target disk (Talos machine.install.disk). Proto plus regenerated Go stubs (protoc-gen-go v1.34.2 / protoc-gen-go-grpc v1.5.1 to match the committed generator). No validation here; cryptos validates. Closes #16
Bugs5382
force-pushed
the
feat/config-install-disk
branch
from
b7b08c2 to
44bb509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Add an
Installmessage with adiskfield toMachineConfig(field 9) so the CryptOS maintenance-mode install flow (Sub-spec 3) can carry the target block device in the machine config, mapping to Talosmachine.install.disk. The new message is ignored by an already-installed node; cryptos owns validation — this contracts repo carries the type only.Closes #16
Verification
task lint)go build ./go/...)task generate)task license)How this was verified
Regenerated with the pinned generators the committed stubs use (protoc-gen-go v1.34.2, protoc-gen-go-grpc v1.5.1) so the diff is limited to
config.proto+config.pb.go(a newer protoc-gen-go otherwise rewrites every stub; tracked as #18).task lint,task generate(no diff),task license(0/0), andgo build ./go/...all green.