Repository navigation
Make current CAPABs the baseline (keep CAPAB negotiation), remove DKEY - #268
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Servers no longer send or parse CAPAB. Every link is treated as BURST, UNCONNECT and NICKIPSTR capable (and NOQUIT when compiled in); ZIP output is still controlled by the connect block Z flag. TLS links remain configured with the S flag. Diffie-Hellman link negotiation (DKEY, connect flag E) could only be enabled through CAPAB and is removed. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Servers send CAPAB again and m_capab() parses it, so new server-to-server capabilities can be negotiated later. The existing capabilities (SSJOIN NOQUIT BURST UNCONNECT ZIP NICKIP NICKIPSTR TSMODE) are advertised but always assumed. A future capability is a CAPAB_ bit plus a servcapabs[] row, gated with IsServCapab()/sendto_capab_serv_butone(). Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration Bot
added a commit
that referenced
this pull request
Oct 28, 2026
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All DALnet servers run current bahamut, so the capabilities that used to be negotiated are now the baseline. The code no longer has a separate "peer lacks X" path for them. The
CAPABcommand itself stays, so new server-to-server capabilities can still be negotiated later.BURST,UNCONNECT,NICKIPSTR,NOQUIT→ always on. The legacy send paths are gone:sendto_server_butone_nickipstr,sendto_non_noquit_servs_butone, the non-NICKIPSTR NICK/TOPIC formats, the non-UNCONNECT SQUIT path, and theIsBurstchecks.ZIP→ controlled only by the connect blockZflag (DoZipThis). TheIsZipCapablehandshake is gone.TLS→ unchanged. It is set at the socket level by the connect/portSflag.DKEY(Diffie-Hellman/RC4) → removed:m_dkey, theDKEYcommand, and connect flagE.dh.c/rc4.care now dead code and can be deleted in a follow-up.CAPAB stays as the extension point:
send_capab()(ins_serv.c) is sent beforeSERVERon both outbound (completed_connection) and inbound (m_server_estab) links. It builds the line fromservcapabs[]. Today it still sendsCAPAB SSJOIN NOQUIT BURST UNCONNECT ZIP NICKIP NICKIPSTR TSMODE, so the wire format is unchanged and older peers still enable their BURST/NICKIPSTR paths.m_capab()sets a bit only forservcapabs[]rows with a non-zero flag. Baseline rows have flag0, and unknown tokens are ignored.sendto_capab_serv_butoneis kept for this.Behavior change: a
connect {}block that still has flagEnow fails to parse that flag. RemoveEfrom configs before upgrading.Testing
tools/testnet(Add tools/testnet: local linked-network test kit with link and CAP tests #270), 3 linked servers, plain+zip and TLS+zip links: all link tests pass with the new build everywhere, with an unmodifiedmasterircd as leaf1, and withmasteras the hub.CAPAB ... FUTURECAP. The hub repliedCAPAB SSJOIN NOQUIT BURST UNCONNECT ZIP NICKIP NICKIPSTR TSMODEbeforeSERVERand ignored the unknown token.Link to Devin session: https://app.devin.ai/sessions/9c171b7fd3d341178646e3cce156ddd7
Open in Devin Desktop: https://app.devin.ai/desktop/session/9c171b7fd3d341178646e3cce156ddd7?variant=devin
Requested by: @eaescob