f60c6735 - Fix OTel span_id fingerprint leak and hub push gap in knock - #52

Open

Danswar wants to merge 35 commits into

developfrom

f60c6735-otel-fingerprint-sync-push

Commits on Sep 1, 2026

Redact OTel trace_id/span_id before hashing the error dedup fingerprint.
Danswar
committed
87ce0d5
Push newly-created local activity to the hub at the end of each knock scan cycle.
Danswar
committed
d3dae25
Address PR review: convention fix, cursor regression guard, daemon crash guard.
Danswar
committed
36d1886
Document the new knock hub push and assert the SystemExit test's log line.
Danswar
committed
421cb03

Commits on Sep 2, 2026

Fix docs to say hub sync (push+pull), not push, and align a test name.
Danswar
committed
bf4e7a8
Harden hub-response handling and widen OTel redaction; document the cursor TOCTOU.
Danswar
committed
b9d289f
Fully validate pull-response shape in _sync_once and raise HubError consistently.
Danswar
committed
0fd5b39
Narrow the knock except clause and propagate the coerced origin_seq.
Danswar
committed
10b718f
Close the remaining hub-data-shape gaps structurally instead of one field at a time.
Danswar
committed
1fbf405
Fix the wake-type frozenset check at its root instead of only catching the crash.
Danswar
committed
1d5d655
Close the last unguarded frozenset check: pending_work() via the restore path.
Danswar
committed
fa6e9b3
Give cmd_restore the same hub-response hardening as _sync_once.
Danswar
committed
3af887f
Parametrize test_restore.py's field-presence tests and fix a docstring overclaim.
Danswar
committed
24d94ba
Cover cmd_restore's non-list-field and unanticipated-shape safety-net paths.
Danswar
committed
8f5a5bb
Widen OTel trace/span redaction to JSON, colon, and quoted-value forms.
Danswar
committed
9d1dd0e
Strengthen the widened OTel redaction tests to check the preserved prefix.
Danswar
committed
fffce6e
Handle escaped-quote OTel log shapes; fix docs and a misleading test fixture.
Danswar
committed
3952097
Fix a second foreign-origin fixture and cover the wake=False guard branch.
Danswar
committed
4b5d397
Cover the missing rejection-side test for cmd_restore's origin_seq coercion.
Danswar
committed
e374edf
Validate payload shape and op value in the shared pull-event/row helpers.
Danswar
committed
0f78e19
Validate table against OWNED_TABLES; close a third payload-corruption entry point.
Danswar
committed
5ef22a6
Guard the new table checks against unhashable values; correct two docstrings.
Danswar
committed
11a2fea
Validate a pulled/restored event's origin_device_id and a snapshot row's updated_at.
Danswar
committed
ee03302
Actually parse a snapshot row's updated_at instead of just checking it's non-empty.
Danswar
committed
65f1faa
Accept a lowercase z UTC designator in a snapshot row's updated_at; fix a docstring.
Danswar
committed
616bf48
Validate a pulled/restored event's occurred_at the same way a snapshot row's updated_at is.
Danswar
committed
a5589cf
Use a real Completed(...) test double instead of a bare None-returning lambda.
Danswar
committed
24cde81
Catch RecursionError from a deeply nested hub response; split the event loop into validate-all-then-apply-all.
Danswar
committed
a4e8bb0
Close the last three gaps in hub-pull shape validation: two more RecursionError paths, row_id/origin_device_id, and restore's session ordering.
Danswar
committed
c42deb5
Revert an unjustified session-ordering change in cmd_restore; make a new RecursionError test deterministic.
Danswar
committed
7dce49f
Remove _sync_once's own sessions-first sort for the same reason its cmd_restore mirror was reverted.
Danswar
committed
10746f5
Match a variable-length OTel id instead of requiring the exact standard length.
Danswar
committed
63876f1
Document the per-cycle hub sync in DESIGN.md's CLI-surface entry for agent knock.
Danswar
committed
706ebeb
Validate every event and snapshot before applying either, in both cmd_restore and _sync_once.
Danswar
committed
8bff953
Correct a comment that overclaimed full validate-before-apply coverage.
Danswar
committed
409d3dd

Navigation Menu

f60c6735 - Fix OTel span_id fingerprint leak and hub push gap in knock - #52

f60c6735 - Fix OTel span_id fingerprint leak and hub push gap in knock#52
Danswar wants to merge 35 commits into
developfrom
f60c6735-otel-fingerprint-sync-push

Commits on Sep 1, 2026

Redact OTel trace_id/span_id before hashing the error dedup fingerprint.

Push newly-created local activity to the hub at the end of each knock scan cycle.

Address PR review: convention fix, cursor regression guard, daemon crash guard.

Document the new knock hub push and assert the SystemExit test's log line.

Commits on Sep 2, 2026

Fix docs to say hub sync (push+pull), not push, and align a test name.

Harden hub-response handling and widen OTel redaction; document the cursor TOCTOU.

Fully validate pull-response shape in _sync_once and raise HubError consistently.

Narrow the knock except clause and propagate the coerced origin_seq.

Close the remaining hub-data-shape gaps structurally instead of one field at a time.

Fix the wake-type frozenset check at its root instead of only catching the crash.

Close the last unguarded frozenset check: pending_work() via the restore path.

Give cmd_restore the same hub-response hardening as _sync_once.

Parametrize test_restore.py's field-presence tests and fix a docstring overclaim.

Cover cmd_restore's non-list-field and unanticipated-shape safety-net paths.

Widen OTel trace/span redaction to JSON, colon, and quoted-value forms.

Strengthen the widened OTel redaction tests to check the preserved prefix.

Handle escaped-quote OTel log shapes; fix docs and a misleading test fixture.

Fix a second foreign-origin fixture and cover the wake=False guard branch.

Cover the missing rejection-side test for cmd_restore's origin_seq coercion.

Validate payload shape and op value in the shared pull-event/row helpers.

Validate table against OWNED_TABLES; close a third payload-corruption entry point.

Guard the new table checks against unhashable values; correct two docstrings.

Validate a pulled/restored event's origin_device_id and a snapshot row's updated_at.

Actually parse a snapshot row's updated_at instead of just checking it's non-empty.

Accept a lowercase z UTC designator in a snapshot row's updated_at; fix a docstring.

Validate a pulled/restored event's occurred_at the same way a snapshot row's updated_at is.

Use a real Completed(...) test double instead of a bare None-returning lambda.

Catch RecursionError from a deeply nested hub response; split the event loop into validate-all-then-apply-all.

Close the last three gaps in hub-pull shape validation: two more RecursionError paths, row_id/origin_device_id, and restore's session ordering.

Revert an unjustified session-ordering change in cmd_restore; make a new RecursionError test deterministic.

Remove _sync_once's own sessions-first sort for the same reason its cmd_restore mirror was reverted.

Match a variable-length OTel id instead of requiring the exact standard length.

Document the per-cycle hub sync in DESIGN.md's CLI-surface entry for agent knock.

Validate every event and snapshot before applying either, in both cmd_restore and _sync_once.

Correct a comment that overclaimed full validate-before-apply coverage.