01a0919c - Isolate per-PR exceptions in the all-open A38 sweep - #96
Open
TaprootFreakAI wants to merge 3 commits into
Open
01a0919c - Isolate per-PR exceptions in the all-open A38 sweep#96TaprootFreakAI wants to merge 3 commits into
TaprootFreakAI wants to merge 3 commits into
Conversation
Collaborator
Author
|
EN: DE: DetailsHead Pass 1 (da568db): Grok quality and logic 0 findings; Codex quality 0; Codex logic 2 findings (invalidate skipped on dual-imported GuardError after publish; action stand-in printed at import). Pass 2 (20704eb): Grok quality 1 finding ( Pass 3 (a46337b): Grok quality, Grok logic, Codex quality, Codex logic all STATUS complete, 0 findings. |
TaprootFreakAI
marked this pull request as ready for review
September 12, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
The all-open A38 sweep now isolates any per-PR exception and keeps scanning, so one fork-approval failure cannot leave Ready conflict PRs unprocessed.
The composite action imports
maininstead of running the module as__main__, soGuardErroridentity matches sibling imports.DE:
Der all-open-A38-Sweep isoliert jede per-PR-Exception und macht weiter, damit ein Fork-Approval-Fehler Ready-Konflikt-PRs nicht unbearbeitet lässt.
Die Composite-Action importiert
mainstatt das Modul als__main__zu starten, damitGuardErrordieselbe Klasse ist wie in den Geschwistermodulen.Details
Production schedule
dfx pr guardon DFXswiss/backend aborted mid-scan with an uncaught traceback:agent_cli.a38_guard.GuardError: fork workflow approval requires the current base to be included in the headpython -m agent_cli.a38_guardexecutes the file as__main__. Sibling modules importGuardErrorfromagent_cli.a38_guard, a second module object. The all-openexcept GuardErrortherefore missed the raised type and killed the rest of the fleet, including Ready pull requests that still had merge conflicts.This change:
Exceptionper PR in the all-open loop (log, error JSON, continue, aggregate exit 1)GuardErroras a guard error in the outermainhandlerfrom agent_cli.a38_guard import main_belongs_to_pullrefusal to approve a fork run whose head does not contain the current baseGuardErrorclass, a plainRuntimeError, single-PR handling, and the action stand-inmainHead:
da568db9fe8e1d17f12fa2729eda25c032294e98