Conversation
Blume1977
force-pushed
the
feat/core-call-queue-phone-times
branch
from
August 3, 2026 13:52
798b9bf to
964ca70
Compare
Blume1977
added a commit
to Blume1977/services
that referenced
this pull request
Sep 14, 2026
The customer's preferred phone-call time was only visible in the call-queue detail view. Compliance staff calling through a phone queue could not see it in the overview and had to open each entry. A new "Phone Call Times" column is shown as the last column before Date, only in the ManualCheckPhone and ManualCheckIpCountryPhone queues (deliberate decision; the other phone queues keep the value in the detail view). The value is the raw, semicolon-separated time slots the customer selected; an empty value shows "-". The neighbouring column labels of the queue list get their missing de/fr/it translations. The value is delivered by the API on CallQueueItem (DFXswiss/backend#3924). Until @dfx.swiss/core carries the field (DFXswiss/packages#180), a small typings bridge exposes phoneCallTimes on CallQueueItem so the screen reads it type-safely; the bridge is removed once core publishes the field. Tests: a unit test brings compliance-call-queue.screen.tsx to full coverage (column visibility per queue, dash for empty values, cell rendering, empty state, error and loading paths, row navigation). The full-stack compliance cases assert the column in the phone queue and its absence in the IP queue; the factory can seed user_data.phoneCallTimes. A visual spec and its handbook metadata are added; the darwin baselines and the reality declarations for the synthetic queue response and the seeded value are declared in the pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Add
phoneCallTimes?: stringto theCallQueueIteminterface of@dfx.swiss/core. The API delivers the field with DFXswiss/backend#5542; this PR only aligns the shared type so the compliance call queue in DFXswiss/app#1449 can show the customer's preferred phone-call times in the list.DE:
Ergänzt das
CallQueueItem-Interface in@dfx.swiss/coreumphoneCallTimes?: string. Die API liefert das Feld mit DFXswiss/backend#5542; hier wird nur der gemeinsame Typ nachgezogen, damit die Compliance-Call-Queue in DFXswiss/app#1449 die bevorzugte Anrufzeit des Kunden in der Liste zeigen kann.Details
Type-only change, no runtime code. Merging to
developtriggerslerna version --conventional-prereleaseand a beta publish via CI; the Conventional Commitfeat(core): …yields the correct beta bump, so no manual version change in this PR.Rollout order: DFXswiss/backend#5542 (independently deployable) → this publish → DFXswiss/app#1449 (bumps
@dfx.swiss/reactand adds the column; until then the app carries a declared local type bridge).