feat(core,react): add the customer recommendation client - #200
Open
TaprootFreak wants to merge 2 commits into
Open
TaprootFreak wants to merge 2 commits into
TaprootFreak wants to merge 2 commits into
Conversation
Contributor
Author
|
Took 2 review passes to reach a clean run. The first pass flagged one thing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of #198: move the customer-facing recommendation contract into the packages.
Changes
@dfx.swiss/coreRecommendationUrl(recommendation,recommendation/:id/confirm,recommendation/:id/reject)Recommendation,CreateRecommendation,RecommendationStatus,RecommendationType,RecommendationMethodRecommendationApiwithlist,create,confirm,reject, wired intoDfxApiClientasclient.recommendation@dfx.swiss/reactuseRecommendation()withgetRecommendations,createRecommendation,confirmRecommendation,rejectRecommendationTests cover all four client methods (
recommendation-api.test.ts).Notes
expirationDateis optional. The API omits it for mail invitations (those do not expire), somodelling it as always present is wrong — a consumer that formats it unconditionally renders an
invalid date for exactly that case.
codeis likewise absent once the code has been used.confirmandrejecttake an id, not the whole recommendation. Nothing but the id reaches thewire, and requiring a full object would force callers to keep one around just to decline.
void; re-read the list to observe the newstatus.
recommendation graph is not part of this contract.
Additive only — no existing export changes shape.
Version fields, changelogs and lockfile pins are untouched, per CONTRIBUTING.