feat(core,react): add the blockchain helper client - #203
Open
TaprootFreak wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Took 2 review passes to reach a clean run. Two things came out of the first pass:
One reported point was not taken: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5 of #198 (the optional one): move the blockchain helper endpoints into the packages, so any
wallet-integrated consumer can read balances and build transfers without a local wrapper.
Changes
@dfx.swiss/coreBlockchainUrl(blockchain/balances,blockchain/transaction,blockchain/broadcast)GetBlockchainBalances,BlockchainBalance,BlockchainBalances,CreateBlockchainTransaction,UnsignedTransaction,BroadcastTransaction,BroadcastResultBlockchainApi, wired intoDfxApiClientasclient.blockchain@dfx.swiss/reactuseBlockchain()withgetBalances,createTransaction,broadcastTransactionTests cover all three calls, including the request without an asset filter.
Notes
createTransactionreturns the raw transaction and its encoding(base64 for Solana, hex elsewhere); decoding and signing it needs a chain library, so it stays with
the caller. Pulling one in here would put a wallet dependency into every consumer of the SDK.
missing from the response entirely — so the response is returned as the API sends it rather than
being pre-joined against an asset list the SDK does not have.
Additive only — no existing export changes shape.
Version fields, changelogs and lockfile pins are untouched, per CONTRIBUTING.