Upgrade RSS to support both Atom and Rss #5849
Open
ConfusionOrb221 wants to merge 4 commits into
Open
Conversation
…link having search before service
…ation_feed_support
lgeggleston
added
the
component: Discovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Extends RSS component to create links in the tag for each defined value inside of
websvc.opensearch.formatscurrently only atom and rss are valid formats. Whichever ones come first in the list will be used for the RSS button on search pages but both/all defined values will be added to the head regardless.Adjusts the title of rel='search' for rss links to be relative to the contex they are defined in e.g RSS links on site (homepage) will be changed to
rel=Sitewide [rsstype (atom/rss)] feed. Whereas community/collection pages will be[Com/Col name] (atom/rss) feed. This also applied to item pages if the rss component is configured their for search. General search will just beSearch [rss/atom] feedInstructions for Reviewers
Use this pr with the REST branch related and you should see rss links created inside of each page's html that the rss component exists (pages with the search component) with the various supported formats. By default this would be both atom and rss but the button on search pages should be configured to the first valid entry in the list.