Skip to content

Format Cargo.toml files with taplo - #12

Draft
DanGould wants to merge 1 commit into
masterfrom
overnight/issue-1016
Draft

DanGould wants to merge 1 commit into
masterfrom
overnight/issue-1016

Conversation

@DanGould

@DanGould DanGould commented Mar 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Extended taplo.toml to reorder keys in [package], [features], [lib], and [package.metadata] sections
  • Ran taplo fmt across all 11 Cargo.toml files for consistent formatting

Closes payjoin#1016

Open questions

  • Should taplo be added to the nix devshell?
  • Should CI enforce taplo fmt --check?

Test plan

  • nix fmt -- --ci passes
  • cargo clippy --all-targets --keep-going --all-features -- -D warnings clean
  • codespell clean
  • taplo fmt --check passes
  • CI passes on fork

Disclosure: co-authored by Claude

Extend the taplo configuration to reorder keys in
[package], [features], [lib], and [package.metadata]
sections in addition to the existing dependency section
rules. Run taplo fmt to apply consistent alphabetical
key ordering across all Cargo.toml files.

This reduces unnecessary merge conflicts caused by
inconsistent key ordering across crates.
@coveralls

coveralls commented Mar 2, 2026 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 22572332455

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.484%

Totals Coverage Status
Change from base Build 22572195695: 0.0%
Covered Lines: 10624
Relevant Lines: 12880

💛 - Coveralls

@DanGould
DanGould force-pushed the overnight/issue-1016 branch from 580a043 to e2223c6 Compare March 2, 2026 10:41
@coderabbitai

coderabbitai Bot commented Mar 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch overnight/issue-1016

Comment @coderabbitai help to get the list of available commands and usage tips.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TOML files are inconsistently formatted

2 participants