Repository navigation
Conversation
Distribute root .gitignore patterns to crate-specific files
so each workspace member documents its own ignored artifacts.
Add explanatory comments to every entry. This is compatible
with jujutsu which reads .gitignore files natively.
Changes:
- Root: keep only workspace-global patterns (target/, Cargo.lock,
IDE settings, mutants.out*, .DS_Store, *.rs.bk, data/)
- payjoin-cli: new file for config.toml and *.sqlite
- payjoin-directory: new file for config.toml, *.ikm, *.dat, data/
- payjoin-mailroom: add config.toml and data/ to existing *.dat
- payjoin-ffi: slim down to __pycache__/ only; patterns moved to
root (IDE/OS) or child dirs (python/, csharp/, dart/)
- payjoin-ffi/{python,csharp,dart,javascript}: add comments and
consolidate patterns previously scattered in parent
- fuzz: add explanatory comments to existing entries
- Delete payjoin/.gitignore (Cargo.lock covered by root)
Closes payjoin#1300
DanGould
force-pushed
the
session4/issue-1300
branch
from
March 2, 2026 10:39
7621982 to
3de9ca4
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
DanGould
force-pushed
the
session4/issue-1300
branch
from
March 2, 2026 10:41
3de9ca4 to
31eb1be
Compare
Pull Request Test Coverage Report for Build 22572327732Details
💛 - Coveralls |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root
.gitignorewas a flat list covering every crate's artifacts, making it hard to tell which patterns belong to which workspace member. This matters for contributors using alternative VCS tools like jujutsu, and for anyone trying to understand what a specific crate produces. Distributing patterns to crate-level files makes each workspace member self-documenting.Closes payjoin#1300
Approach
Move crate-specific ignore patterns (build artifacts, test fixtures, generated files) from the root
.gitignoreinto per-crate.gitignorefiles forpayjoin-cliandpayjoin-directory, creating those files where they didn't exist. The root.gitignoreis left with only workspace-global patterns (target/,Cargo.lock, IDE settings,mutants.out*,data/). Every entry across all.gitignorefiles gets an explanatory comment so future contributors know why each pattern exists.Open questions
None
Disclosure: co-authored by Claude