Fix broken dio - #700
Merged
Merged
Conversation
Add a fallback mechanism to try both URLs.
Provide the adaptive selection toolbar for `SelectableLinkifyX`.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses network/session regressions and UX issues by pinning dio to a known-good version, strengthening session reset behavior on restart, updating the postgraduate timetable endpoint selection, and restoring the default text selection context menu for linkified selectable text.
Changes:
- Pin
dioto5.10.0to avoid interceptor breakage in5.11.0. - Update postgraduate timetable fetching to try a primary endpoint with fallback to a secondary endpoint.
- Ensure Fudan session state is fully reset on restart and restore default selection context menu behavior for selectable linkified text.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Pins dio to 5.10.0 with a TODO note to upgrade after upstream fix. |
| pubspec.lock | Updates locked dio version/hash to 5.10.0. |
| lib/widget/libraries/linkify_x.dart | Restores default selectable text context menu via contextMenuBuilder. |
| lib/util/flutter_app.dart | Awaits Fudan session clearing during app restart and guards with context.mounted. |
| lib/repository/fdu/postgraduate_timetable_repository.dart | Adds primary/secondary endpoint retry logic for PG timetable fetch. |
| lib/repository/fdu/neo_login_tool.dart | Rebuilds authentication queues and closes Dio client during session clear; adjusts login batching logic placement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: