Skip to content

Fix broken dio - #700

Merged
w568w merged 4 commits into
mainfrom
fix-broken-dio
Aug 30, 2026
Merged

Fix broken dio#700
w568w merged 4 commits into
mainfrom
fix-broken-dio

Conversation

@w568w

@w568w w568w commented Aug 30, 2026

Copy link
Copy Markdown
Member

This PR:

  • Fix the critical issue that dio stops working because of interface regression by downgrading dio
  • Update the postgraduate timetable endpoint
  • Fix the 500 Error after signing out by reseting Fudan network session state on app restart/phoneixed
  • Add selection context menu for selectable text

@w568w w568w added this to the 1.5.3 milestone Aug 30, 2026
@w568w
w568w requested a lite review from Copilot August 30, 2026 10:41
@w568w w568w added the bug Something isn't working label Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses network/session regressions and UX issues by pinning dio to a known-good version, strengthening session reset behavior on restart, updating the postgraduate timetable endpoint selection, and restoring the default text selection context menu for linkified selectable text.

Changes:

  • Pin dio to 5.10.0 to avoid interceptor breakage in 5.11.0.
  • Update postgraduate timetable fetching to try a primary endpoint with fallback to a secondary endpoint.
  • Ensure Fudan session state is fully reset on restart and restore default selection context menu behavior for selectable linkified text.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pubspec.yaml Pins dio to 5.10.0 with a TODO note to upgrade after upstream fix.
pubspec.lock Updates locked dio version/hash to 5.10.0.
lib/widget/libraries/linkify_x.dart Restores default selectable text context menu via contextMenuBuilder.
lib/util/flutter_app.dart Awaits Fudan session clearing during app restart and guards with context.mounted.
lib/repository/fdu/postgraduate_timetable_repository.dart Adds primary/secondary endpoint retry logic for PG timetable fetch.
lib/repository/fdu/neo_login_tool.dart Rebuilds authentication queues and closes Dio client during session clear; adjusts login batching logic placement.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/repository/fdu/postgraduate_timetable_repository.dart
@w568w
w568w merged commit 53e47f3 into main Aug 30, 2026
1 check passed
@w568w
w568w deleted the fix-broken-dio branch August 30, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants