[NOJIRA] fix: add modulesProvider to packages with TurboModules - #1370
Merged
marco-saia-datadog merged 1 commit intoAug 13, 2026
Merged
Conversation
marco-saia-datadog
changed the title
modulesProvider to packages with TurboModules
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates React Native package codegenConfig metadata to support iOS New Architecture codegen by providing an explicit TurboModule spec → Objective‑C class mapping via codegenConfig.ios.modulesProvider.
Changes:
- Added
codegenConfig.ios.modulesProviderto@datadog/mobile-react-native(core) for its TurboModules (DdFlags,DdLogs,DdRum,DdSdk,DdTrace). - Added
codegenConfig.ios.modulesProviderto@datadog/react-native-session-replayforDdSessionReplay.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-native-session-replay/package.json | Adds iOS modulesProvider mapping for the Session Replay TurboModule. |
| packages/core/package.json | Adds iOS modulesProvider mapping for core TurboModules used by the SDK. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+117
to
+121
| "ios": { | ||
| "modulesProvider": { | ||
| "DdFlags": "DdFlags", | ||
| "DdLogs": "DdLogs", | ||
| "DdRum": "DdRum", |
Collaborator
There was a problem hiding this comment.
May be worth making the change here too
marco-saia-datadog
force-pushed
the
marcosaia/fix/modules-provider-in-package-json
branch
from
August 13, 2026 15:52
6153d23 to
255f2fc
Compare
cdn34dd
approved these changes
Aug 13, 2026
marco-saia-datadog
deleted the
marcosaia/fix/modules-provider-in-package-json
branch
August 13, 2026 19:34
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
codegenConfig.ios.modulesProviderto packages with TurboModules.Motivation
New Architecture's iOS codegen needs to resolve each TurboModule spec to its concrete Objective-C class. It does this via
codegenConfig.ios.modulesProviderinpackage.json. This is a static, compile-time map from spec name to class name. It replaces the old bridge's runtimeNSClassFromStringdiscovery.See the official docs: https://reactnative.dev/docs/turbo-native-modules-introduction (the
modulesProviderfield in thecodegenConfig.iosexample).Our packages'
codegenConfignever declared anioskey. So this mapping was missing, and it seems to cause issues in Expo 57+.Review checklist (to be filled by reviewers)