Prevent fork PR comment failures from blocking schema validation - #37
Merged
Conversation
Fork PRs get a read-only GITHUB_TOKEN regardless of workflow-level permissions, so the auto-comment step 403s and fails the required status check even when schema validation itself passed. Mark the comment steps continue-on-error so validation results still gate merges without granting forks write access.
sethsec
requested review from
andrewkrug,
christophetd and
raesene
as code owners
August 17, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_TOKENfrom GitHub regardless of thepermissions:block in the workflow, so the "Comment on PR" steps 403 withResource not accessible by integration.validatejob (and thus the required status check) even when schema validation itself passed cleanly.continue-on-error: trueto both comment steps so a failed comment doesn't block merging, without granting forks any elevated permissions (nopull_request_target, no workflow permission changes).Test plan
deploy.yml(GitHub Pages deploy) is unaffected — it only triggers on push tomain, unrelated workflow