Repository navigation
Define TAP_TESTS before including PGXS - #90
Open
tristan957 wants to merge 1 commit into
Open
tristan957 wants to merge 1 commit into
tristan957 wants to merge 1 commit into
Conversation
pgxs.mk only defines the TAP test rules, such as the prove step of installcheck, when TAP_TESTS is already set. The Makefile set it after including PGXS, so "make installcheck" never ran the tests in t/. Move the assignment above the include. Signed-off-by: Tristan Partin <tristan@partin.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pgxs.mk only defines the TAP test rules, such as the prove step of installcheck, when TAP_TESTS is already set. The Makefile set it after including PGXS, so "make installcheck" never ran the tests in t/.
Move the assignment above the include.
Motivation
PG 19 support.