test(ffe): use checked-in canonical fixture snapshot - #7511
Draft
leoromanovsky wants to merge 1 commit into
Draft
Conversation
Contributor
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Attach the canonical
DataDog/ffe-system-test-datacorpus tosystem-testswithout requiring submodules.This follows the checked-in snapshot and automated updater model merged in dd-trace-dotnet#8616. Local and CI tests work from a normal clone, while upstream fixture changes still arrive through an automated draft PR.
This supersedes the fixture transport proposed in #6594 and #6901. Those drafts used a git submodule and required initialization changes throughout CI.
Changes
ffe-system-test-data@ea8b5cc.errorCode.Decisions
system-teststhrough a client-owned disallow list. The updater also validates refs and fixture structure and rejects symbolic links.peter-evans/create-pull-requestsigned-commit pattern.Verification
python3 utils/scripts/update_ffe_fixtures.py --ref ea8b5cc5ce335109f11f3efbc5fd608f98a3ca54changed: false../run.sh TEST_THE_TEST tests/test_the_test/test_update_ffe_fixtures.py: 13 passed../run.sh TEST_THE_TEST tests/test_the_test/test_mock_ffe_agentless_backend.py: 7 passed.git diff --check: passed.The initial snapshot exactly matches the merged .NET snapshot except for its generated repository-specific
SOURCE.md.Workflow
ffe-system-test-data.