test(cpp): enable otel tracestate sampling - #7522
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0378ec0860
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: d712e83 | Docs | View more details | Give us feedback! |
8f5e665 to
7038c67
Compare
b02e7fd to
90f5085
Compare
|
🤖 Comment from Claude (via Claude Code), reviewing this PR at a user's request. I think I reimplemented the sampling formula documented in and verified it reproduces the existing, already-verified Applying that same validated formula to the two new boundary vectors:
In both cases the |
@dougqh This is intentional. In these edge cases the imprecision comes initially from computing |
7038c67 to
cb69bdf
Compare
9066827 to
ca247bc
Compare
test(cpp): enable otel tracestate sampling test(cpp): require tracestate sampling after 2.2.0 test(cpp): disable otlp tracestate sampling
ca247bc to
87118b9
Compare
Enables C++ OpenTelemetry tracestate sampling coverage. Stacked on #7518.