test(ffe/go): un-flaky Degradation and gate ObserveFullData PII tests to v2.11.0-dev - #7535
Open
vjfridge wants to merge 1 commit into
Open
test(ffe/go): un-flaky Degradation and gate ObserveFullData PII tests to v2.11.0-dev#7535vjfridge wants to merge 1 commit into
vjfridge wants to merge 1 commit into
Conversation
Enable the four previously-disabled tests/ffe/test_flag_eval_evp.py classes for the Go tracer so they inherit the file-level v2.10.0-dev enablement: - Test_FFE_EVP_Flagevaluation_Degradation (was flaky, FFL-2676) - Test_FFE_EVP_Flagevaluation_ObserveFullData_Absent_Hashed (FFL-2784) - Test_FFE_EVP_Flagevaluation_ObserveFullData_False_Hashed (FFL-2784) - Test_FFE_EVP_Flagevaluation_ObserveFullData_True_Unhashed (FFL-2784) The dd-trace-go PII-protection branch (vickie/ffl-2962-protecting-pii-in-flagevaluations-track) implements the observeFullEvaluationData UFC consent metadata and SHA-256 targeting_key hashing that these tests assert against. Validated locally against that branch: all 11 EVP end-to-end tests pass in the FEATURE_FLAGGING_AND_EXPERIMENTATION scenario, and the parametric FFE suite passes with no failures. Generated with Claude Code
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Go EVP
flagevaluationbase track shipped in dd-trace-go v2.10.0 (#4886), but the PII-protection layer —observeFullEvaluationDataconsent + SHA-256targeting_keyhashing — landed later in dd-trace-go#5151 (merged tomain, targeting v2.11.0). This PR aligns the Go system-tests manifest with that split:Test_FFE_EVP_Flagevaluation_Degradation) was markedflaky (FFL-2676)in skip failing tests for FFL-2676 #7268. It now passes cleanly against the v2.10.0 base track (verified locally in dd-trace-go#5151 L3: 11/11test_flag_eval_evppassed including Degradation). Remove the flaky gate so it runs on v2.10.0.Absent_Hashed,False_Hashed,True_Unhashed) were added asmissing_feature (FFL-2784)in FFL-2783: add tests for observeFullEvaluationData PII protection (gated as missing_feature) #7316. They assert the PII-hashing behavior from dd-trace-go#5151, which is not in v2.10.0. Re-gate them tov2.11.0-dev(the first dev tag containing the merged [python] test fix for django on python 3.13 #5151) so they skip on v2.10.0 and run on v2.11.0-dev.Changes
```diff
tests/ffe/test_flag_eval_evp.py: v2.10.0-dev
```
Validation
FEATURE_FLAGGING_AND_EXPERIMENTATIONscenario,golang@2.11.0-dev.1/net-http→ 26 passed, 2 skipped, 0 failed.test_flag_eval_evp.py11/11 passed including Degradation and the three ObserveFullData tests.🤖 Generated with Claude Code