Skip to content

fix(histogram): restore temporal execution and rendering - #1543

Merged
kentwelcome merged 2 commits into
feature/drc-4262-legacy-histogram-reject-parameterized-and-spelled-timefrom
feature/drc-4216-legacy-histogram-restore-datetimestamp-rendering-for-saved
Sep 4, 2026
Merged

kentwelcome merged 2 commits into
feature/drc-4262-legacy-histogram-reject-parameterized-and-spelled-timefrom
feature/drc-4216-legacy-histogram-restore-datetimestamp-rendering-for-saved

Conversation

@gcko

@gcko gcko commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

Bugfix

What this PR does / why we need it:

  • Restores additive daily, monthly, yearly, and extreme-date histogram geometry.
  • Preserves a successful side when the other warehouse query fails and gives partial results a stable payload.
  • Normalizes supported temporal wire values deterministically to UTC epoch milliseconds.
  • Renders temporal bins at interval midpoints with edge-derived chart bounds and readable UTC labels.
  • Makes the Chart.js date adapter a real shared-UI runtime dependency and covers saved/direct DATE, TIMESTAMP, and TIMESTAMPTZ results.

Which issue(s) this PR fixes:

Closes DRC-4216

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Yes.

Saved and direct DATE and timestamp histograms now execute and render with stable UTC boundaries, including partial-result and extreme-date cases.

@gcko gcko changed the title feature/drc 4216 legacy histogram restore datetimestamp rendering for saved fix(histogram): restore temporal execution and rendering Sep 4, 2026
@gcko gcko self-assigned this Sep 4, 2026
@gcko
gcko requested a review from kentwelcome September 4, 2026 08:30

@kentwelcome kentwelcome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gcko and others added 2 commits September 4, 2026 17:15
DRC-4216

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jared Scott <jared.scott@datarecce.io>
DRC-4216

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jared Scott <jared.scott@datarecce.io>
@kentwelcome
kentwelcome force-pushed the feature/drc-4216-legacy-histogram-restore-datetimestamp-rendering-for-saved branch from 0ee8d8c to 4ca7226 Compare September 4, 2026 09:15
@kentwelcome
kentwelcome merged commit 31e2d9e into main Sep 4, 2026
25 checks passed
@kentwelcome
kentwelcome deleted the feature/drc-4216-legacy-histogram-restore-datetimestamp-rendering-for-saved branch September 4, 2026 09:21
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.61404% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
recce/tasks/histogram.py 87.50% 5 Missing ⚠️
Files with missing lines Coverage Δ
tests/tasks/test_histogram.py 99.66% <100.00%> (+0.10%) ⬆️
recce/tasks/histogram.py 90.96% <87.50%> (+15.22%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants