Repository navigation
chore(track): include the installed dbt version in the command event - #1552
Merged
Merged
Conversation
Recce OSS fails to start when dbt v2 is the only dbt in the environment, because dbt v2 drops the Python modules the dbt adapter imports. In the event data that failure looks the same as a machine with no dbt installed, so we cannot count the users it affects. The command event now carries the installed dbt version. The value comes from package metadata, not from an import, so it still arrives when the dbt import is what failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
wcchang1115
marked this pull request as ready for review
September 16, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
chore
What this PR does / why we need it:
Recce OSS does not start when dbt v2 is the only dbt in the environment. dbt v2 ships the warehouse drivers inside a Rust binary and drops the Python modules that the dbt adapter imports.
We cannot tell how common this is. A run that fails on the missing dbt modules looks the same as a run on a machine with no dbt installed at all.
This PR adds one property,
dbt_version, to thecommandevent that Recce already sends. It adds no new event, and the existinganonymous_trackingopt-out still gates it.Which issue(s) this PR fixes:
Special notes for your reviewer:
The property sits in the
finallyblock ofTrackCommand.invoke, so it also arrives when the command fails. That failing run is the case this is for.Checked against a real dbt v2 environment: the property reports
2.0.2when the command fails on the missing dbt 1.x import.Does this PR introduce a user-facing change?:
NONE