Repository navigation
fix: restore Boot 4 telemetry and WebSocket contracts with migrated coverage - #271
Merged
Merged
Conversation
DavidHLP
marked this pull request as ready for review
October 11, 2026 06:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 029a5d6fc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DavidHLP
changed the title
DavidHLP
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore coverage and configuration contracts after the Boot4 migration. Two Judge suites stayed disabled: source selection was replaced by a placeholder, and envelope tests could not load harness fixtures. Restore four source-selection regressions and six existing envelope tests using the four canonical harness JSON resources.
The source-selection tests verify both configuration modes and that empty or failing canonical cases never fall back to legacy examples. Remove the disabled empty Contest placeholder and its stale Javadoc; preserve all13 existing Contest cases. Fix OTLP metrics opt-in bindings for Auth/Admin/App/Core, restore Submission metrics to management.otlp.metrics.export, and independently select Jackson2 for App/Core WebSocket messaging. The existing observability contract now checks all8 service metrics configurations and both WebSocket selectors; canonical OPERATIONS is updated. Authentication, authorization, database and business message logic are unchanged.
Validation: specification, standards and Java reviews approved the configuration repair and main integration; whitespace checks passed. At422ee6763345bc99617e1e80da8ca89dddb98ca2, the complete remote observability contract returned0. Its current YAML checks passed and11 in-memory negative cases were rejected: eight wrongly enabled metrics defaults, old Submission nesting, and both missing WebSocket selectors. Fresh CI and AST update are pending. Prior e76c3ef passed23 checks after Contest cleanup. Prior029a5d6fc Backend Test and independent remote default-profile focused execution each confirmed6 envelope+4 source-selection tests with zero failures/errors/skips; the independent run completed exit0 with all7 modules successful (12m47s). Judge source and the13 Contest cases are unchanged. Prerequisite PR270 is merged after independent full default Maven verify succeeded. Live Collector, WebSocket/Redis wire equivalence and Docker sandbox acceptance are not claimed.