Repository navigation
Conversation
Adds docs/architecture-analysis.md: a health-check audit across architecture, security, code quality, and deployability. Security hypotheses were live-probed against a throwaway copy of the SQLite DB with the real _devExtensions mounted under soul-cli. Headline findings: - Critical: unauthenticated account takeover via /api/insert-password (extension routes mount with no auth middleware; currentPassword validation is skipped when absent). - Critical: SQL injection in insertPasswordRecord (string-interpolated INSERT). - Corrects a plausible static-only conclusion: soul-cli DOES enforce per-table/per-verb RBAC on /api/tables/* (verified via live 401/403), and audit is append-only for non-superusers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014iXShVboo1ppN2JkAuootr
|
Not up to standards ⛔
|
IanMayo
changed the title
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been withdrawn and closed. Its contents were removed at the author's request pending internal follow-up.
Please delete this pull request entirely (org-owner action) to remove any remaining history.
Generated by Claude Code