Repository navigation
Fix/pre release issues - #82
Merged
Merged
Conversation
…to the binary - Default to port 14123 and to running migrations on startup, as the README and Dockerfile already state. An unset DLA_DB_AUTO_MIGRATE used to fall through to DB.init's `false`. - In the compiled binary, `import.meta.dir` is Bun's virtual /$bunfs/root, and `path.join` glued even an absolute DLA_DB_MIGRATION_DIR onto it, so the Docker image couldn't find its migrations. Absolute paths are now used as they are, and relative ones resolve next to the executable.
- `depends_on` named a service `api` that doesn't exist (it is `delivr-api`), so `docker compose` refused the file. - The web image reads DELIVR_* only while it is built, so set the URLs and the signup switch through Nuxt's runtime NUXT_PUBLIC_* overrides.
Bun's Request has no `remoteAddr`, so every client was keyed as "unknown" and the per-address limit acted as a second per-username limit. Read the socket address with `getConnInfo` instead, or the last X-Forwarded-For entry when the new DLA_TRUST_PROXY is set.
DELETE /admin/users/:userId removed only the user row, its sessions, API keys and password resets. SQLite doesn't enforce the foreign keys, so the user's mail accounts (with their encrypted credentials), identities, special-use mappings and preferences stayed behind. - AccountDeletionService now does every user and mail account deletion. It is synchronous, because the bun-sqlite driver commits an async transaction callback at its first `await`, which would leave nothing to roll back. - The admin route closes the removed accounts' pooled IMAP connections. MailClientsCache.deleteClient no longer throws when the logout fails. - Migration 0015 purges data already orphaned this way.
The PostgreSQL and MySQL schemas are kept in sync, but nothing wires up those drivers yet (#10).
Restores DELIVR_API_URL, DELIVR_APP_URL and DELIVR_ENABLE_SIGNUP in the full-stack compose file and the CLAUDE.md note. The depends_on fix stays.
Login rate limiting keys on the socket address only, so X-Forwarded-For is always ignored. Removes the setting from the config, example.env, the README, the test preload and CLAUDE.md, along with its test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.