ci: apply formatting in check instead of gating it - #33
Merged
Merged
Conversation
`just check` now formats first (rustfmt + oxfmt) and then runs lint/type-check/tests, matching the previous `prettier -w` behavior; `cargo fmt` no longer uses `--check`. The formatting step lives in the `check` recipe per kind, so the separate `fmt` recipe is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just checkformats before it lints/type-checks, and the formatting step lives in thecheckrecipe per kind instead of a separatefmtrecipe.just check rust:cargo fmt(wascargo fmt -- --check) — rustfmt now applies instead of only verifying.just check js:oxfmt(write) — unchanged from main; the formatting step is simply part of the check flow.checkdocuments that formatting is applied first; no standalonefmtrecipe.Formatting is therefore applied, not gated: the gate remains oxlint +
vue-tsc+ clippy + tests.Verified:
just check jspasses and leaves a clean tree.