Conversation
### Description This pull request addresses a high-severity robustness and denial-of-service finding in `zkwasm-mini-rollup` (`dbservice/src/main.rs`) identified during the DelphinusLab workspace security audit (**F25**). Previously, client-supplied inputs across JSON-RPC handlers (`update_leaf`, `get_leaf`, `update_record`, and `get_record`) were unwrapped directly using `.unwrap()`, and underlying storage-layer calls panicked on unexpected input states. An attacker submitting malformed index strings or invalid record arrays could trigger worker thread panics, leading to remote service crashes and DoS. ### Key Changes & Remediations #### Fallible Input Parsing & Safe Error Mapping (F25 - `dbservice/src/main.rs`) * **Strict Parameter Parsing:** Replaced unwrap calls on client-supplied index strings in `update_leaf` and `get_leaf` with `u64::from_str_radix(..., 10).map_err(|_| Error::INVALID_PARAMS)?`. * **Record Validation:** Pre-validated record data elements in `update_record` before dispatching to the blocking worker task, returning `Error::INVALID_PARAMS` on any invalid numeric string. * **Graceful Storage Error Handling:** Mapped storage failures (`update_leaf_data_with_proof`, `get_leaf_with_proof`, and `get_record`) to `Error::INTERNAL_ERROR` instead of permitting panics inside `actix_web::web::block`. ### How to Review 1. Inspect `dbservice/src/main.rs` to verify that all `.unwrap()` calls on client-supplied parameters and fallible database queries have been replaced with `?` and mapped to JSON-RPC error types. 2. Confirm that malformed requests now gracefully return JSON-RPC error responses rather than terminating the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a high-severity robustness and denial-of-service finding in
zkwasm-mini-rollup(dbservice/src/main.rs) identified during the DelphinusLab workspace security audit (F25).Previously, client-supplied inputs across JSON-RPC handlers (
update_leaf,get_leaf,update_record, andget_record) were unwrapped directly using.unwrap(), and underlying storage-layer calls panicked on unexpected input states. An attacker submitting malformed index strings or invalid record arrays could trigger worker thread panics, leading to remote service crashes and DoS.Key Changes & Remediations
Fallible Input Parsing & Safe Error Mapping (F25 -
dbservice/src/main.rs)update_leafandget_leafwithu64::from_str_radix(..., 10).map_err(|_| Error::INVALID_PARAMS)?.update_recordbefore dispatching to the blocking worker task, returningError::INVALID_PARAMSon any invalid numeric string.update_leaf_data_with_proof,get_leaf_with_proof, andget_record) toError::INTERNAL_ERRORinstead of permitting panics insideactix_web::web::block.How to Review
dbservice/src/main.rsto verify that all.unwrap()calls on client-supplied parameters and fallible database queries have been replaced with?and mapped to JSON-RPC error types.