fix(frontend): keep portal editor context and drop handled chunk-error noise - #1032
Draft
posthog-eu[bot] wants to merge 1 commit into
Draft
Conversation
…r noise
Two frontend fixes:
- The legal basis card's "Workspace settings" link navigated in place, so a
host filling in the portal editor lost their form and workspace settings
offered no way back. It now opens in a new tab, matching its external-link
icon and keeping the editor open.
- Stale-deploy chunk misses ("Unable to preload CSS for ...", "Failed to fetch
dynamically imported module") are already recovered by recoverFromChunkFailure,
but the vite:preloadError listener rethrows on purpose, so autocapture files a
fresh error tracking issue on every deploy. A posthog before_send now drops
this message class. The app_version_reloaded event stays the health metric.
Generated-By: PostHog Desktop
Task-Id: 106ec2d4-eada-4995-b904-b142c71713f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Unable to preload CSS for /assets/<Route>-<hash>.css,Failed to fetch dynamically imported module).Neither signal shows broad user harm (P3). The full context is in the linked report.
Changes
target="_blank",hrefwith the active language prefix), so the editor form stays open. This replaces the in-placenavigate(...)call.before_send.recoverFromChunkFailurealready reloads a stale tab onto the new build, but thevite:preloadErrorlistener rethrows on purpose (cancelling it makes Vite resolve the import toundefinedand throw a misleading error). A newbefore_sendfilter drops$exceptionevents whose message is a Vite preload/dynamic-import miss. Theapp_version_reloadedevent stays the health metric.Why the vision scanner's "app reverts the page" reading is not the cause
There is no automatic redirect in
ProjectLegalBasisSection.tsx. The context loss is real, but it comes from the in-place link, not a page revert.Tests
pnpmlocal binaries:tsc --noEmitandbiome checkpass on the changed files.isChunkLoadErrorMessageunit tests (browser message variants match; unrelated exceptions and nullish input do not). FullappVersion.test.tssuite: 16 passed.Created with PostHog Desktop from this inbox report.