feat(chat): restore conversation-scoped ask from conversation view and sidebar - #1057
Open
dembrane-sam-bot wants to merge 1 commit into
Open
feat(chat): restore conversation-scoped ask from conversation view and sidebar#1057dembrane-sam-bot wants to merge 1 commit into
dembrane-sam-bot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavItemforwardsstate.selectedConversationIds).ProjectConversationRoute), gated for non-observer roles and unlocked conversations.NewChatRouteto readconversationId/conversation_idfrom URL search params in addition to router state.Fixes ECHO-975
Context
Reported by Pauline in #gen-engineering: clicking Ask from within a conversation previously pre-selected that conversation as the scope, but this was lost when sidebar navigation was decoupled from conversation context and there was no direct action inside the conversation view.
Confidence
High. The pre-selection and focus chip logic in
NewChatRouteis already fully implemented; this wires the missing entry points.