refactor(templates): drop orphaned classic scaffolding and deprecated shims#272
Merged
Conversation
… shims These template types have no remaining consumers and were already slated for removal: the orphaned CoverLetterTemplate and WeeklyScheduleTemplate contracts, the deprecated-for-removal CV HeadlineRenderer/ContactRenderer/ BannerRenderer shims, the WeeklyScheduleTemplateV1 builtin, and the never-shipped classic invoice/proposal stub scaffolding (presets/builder/ spec) that only its own smoke tests exercised. The shipping invoice and proposal surface is the layered v2 preset stack. Remove those types and the two classic smoke tests. Repoint the invoice/ proposal package docs at the v2 stack, point DocumentTemplate's @param example at the v2 InvoiceDocumentSpec/ProposalDocumentSpec, and drop the two stability-ledger rows that tracked the now-removed types. Tests: ./mvnw verify javadoc:javadoc -pl . — 1621 tests, 0 failures, javadoc gate clean; examples and benchmarks compile against the new jar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
First leaf of the 2.0 template cleanup: remove template types that have no remaining consumers and were already slated for removal. All are verified zero-consumer orphans (no implementers, no importers, no reflection/
META-INF/services/string-FQN references).What
Removed:
templates.api.CoverLetterTemplate(orphan interface, deprecated-for-removal since 1.9) andtemplates.api.WeeklyScheduleTemplate(only implementer wasWeeklyScheduleTemplateV1, removed here).templates.cv.v2.components.{HeadlineRenderer,ContactRenderer,BannerRenderer}— deprecated-for-removal pre-widgets shims, no callers.templates.builtins.WeeklyScheduleTemplateV1— orphan builtin.templates.{invoice,proposal}.{presets,builder,spec}(each consumed only by its own smoke test) + the two classic smoke tests. The surviving invoice/proposal surface is the layered*/v2preset stack.Survivor edits: repointed the invoice/proposal package docs at the v2 stack, pointed
DocumentTemplate's@paramexample atInvoiceDocumentSpec/ProposalDocumentSpec, and dropped the twoapi-stability.md§3 ledger rows that tracked the removed types.Tests
./mvnw verify javadoc:javadoc -pl .— 1621 tests, 0 failures, javadoc gate clean.examplesandbenchmarksmodules compile against the new jar. japicmp runs report-only on this line.