refactor(templates): remove the classic CV family#277
Merged
Conversation
The Gen-2 CV stack (cv.{presets,builder,spec,layouts} + data.cv) is
superseded by the layered cv.v2 surface — the last classic template family,
completing the Gen-2 removal.
Delete the classic CV packages, their tests, the CvTestFixtures /
CvDocumentSpecMock fixtures, and the now-orphaned templates.api.SlotMap (the
carrier between the deleted CvBuilder and CvLayout, with no other consumer).
Repoint the four CV benchmarks onto cv.v2.presets.ModernProfessional and a
new com.demcha.mock.CvDataFixtures.canonicalCv() v2 CvDocument fixture
(sibling of the invoice/proposal fixtures) — the benchmarks now render the
v2 CV, a different renderer, so absolute numbers shift. Strip the classic
sampleCv / sampleHeader from ExampleDataFactory and repoint the cv and data
package-info docs at the v2 surface.
Tests: ./mvnw verify javadoc:javadoc -pl . — 1458 tests, 0 failures, javadoc
clean; benchmark gates + perf-smoke (v2 CV renders) + examples-generation
smoke (85) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Gen-2 CV stack (
cv.{presets,builder,spec,layouts}+data.cv) is superseded by the layeredcv.v2surface. This is the last classic template family — with it gone, the entire Gen-2 classic estate (cv + cover-letter + builtins) is removed.What
CvTestFixtures/CvDocumentSpecMockfixtures. Keep + repointcv/package-infoatcv.v2. All ofcv.v2is untouched (its 14 presets are name-twins of the classic ones in a different package).templates.api.SlotMap(+ its test) — it was the carrier between the deletedCvBuilderandCvLayout, with no other consumer.CanonicalBenchmarkSupport,CurrentSpeedBenchmark,jmh.ColdStartJmhBenchmark,jmh.TemplateCvJmhBenchmark) now usecv.v2.presets.ModernProfessional.create()+ a newcom.demcha.mock.CvDataFixtures.canonicalCv()v2CvDocumentfixture (sibling of the invoice/proposal fixtures). The benchmarks now render the v2 CV — a different renderer, so absolute numbers shift.sampleCv()/sampleHeader()fromExampleDataFactory; repoint thecv+datapackage-info docs.Tests
./mvnw verify javadoc:javadoc -pl .— 1458 tests, 0 failures, javadoc clean. Benchmarkstest+ the perf-smoke run (CurrentSpeedBenchmarksmoke — the v2 CV renders, no overflow) + examples-generation smoke (85) all green. japicmp report-only on this line.