FormattedTextHelper: stricter URL parsing#2832
Open
tal5 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on Discord.
TL;DR Adventure more strictly verifies URLs now which revealed some issues where the parser would end up including invalid characters in the embedded URL.
Can be solved by simply adding more characters to the
indexOfAnycheck, but I decided to try a different approach and use a whitelist of valid characters to find the first non-url-valid character and end the theoretical URL there.I also added an additional length check after the exact URL end index is found, just as a quick exit in some edge cases.
This also adds a
new URI(url)test in atry/catch, as a final verification before adding the URL click event to the component.Quick test of the logic:
Results in: