fix: make release artifacts fully offline - #582
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit cafa0c2): https://on-time-front-widgetbook--pr-582-fmwqub7i.web.app (expires Tue, 01 Sep 2026 01:55:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e53128a376fed0209d449279de9c0d94c83cdd8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
App Store Connect rejected build 1.1.0 (56) with error 91011 because the prebuilt libsodium.framework contained an arm64e slice compiled with the iOS 18.5 SDK. Xcode 26 requires arm64e slices to be built with the iOS 26 SDK or later. The official sodium 4 native-asset path compiles libsodium with the active SDK and produces an arm64-only iOS framework.
The web bootstrap also still loaded Google Sign-In, Firebase Messaging, and SQLite WASM from remote servers, which violated the product local-only boundary despite the Dart and native source gates passing.
Behavior and lifecycle
Backup creation and restore keep the same version 1 container, KDF parameters, authenticated encryption, password failure behavior, and atomic restore behavior. Native libsodium initialization is now supplied by sodium build hooks. Web startup loads every required runtime artifact from the deployed bundle and registers only the Flutter offline cache service worker.
Persistence and migration
No database, backup format, or user-data migration. Existing encrypted backups remain readable because algorithms, parameters, framing, and authenticated metadata are unchanged.
Concurrency and idempotency
Password derivation still runs through Sodium.runIsolated. Repeated dependency generation and release builds are stable. Reinstalling or updating the app does not rewrite existing local data.
Validation
Out of scope
Follow-up to #580 and #581.