Repository navigation
Add post-auth connection binder hook #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Rui Carmo (rcarmo)
wants to merge
1
commit into
Devolutions:master
from
rcarmo:wrdp/post-auth-connection-binder
+84
−5
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Post-auth connection binding for multi-user servers | ||
|
|
||
| `wrdp` follows the same multi-user architecture model as `xrdp-sesman`: a | ||
| single public RDP listener authenticates the client first, then delegates the | ||
| connection to a per-user desktop/session stack. | ||
|
|
||
| That model needs a server hook that runs after credentials have been accepted | ||
| but before display updates and input dispatch begin. The hook lets a server | ||
| start or locate the authenticated user's session and then replace placeholder | ||
| handlers with display/input handlers bound to that session. | ||
|
|
||
| The `ConnectionBinder` API keeps protocol ownership inside IronRDP while | ||
| allowing downstream servers to keep user/session lifecycle code outside the RDP | ||
| state machine. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on the canonical
rcarmo/IronRDP:wrdpbranch in3b05f6fc70d91c2529df8454ce73a292c05195e6: the connection binder is now guarded with!result.reactivation, so it runs only for the initial accept on a TCP connection. Reactivation now skips rebinding and preserves the installed display/input handlers.