Skip telemetry work when it cannot be sent#5071
Merged
Merged
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the telemetry system by ensuring that telemetry events are only collected and sent when telemetry is enabled and valid OpenSearch credentials are configured. This prevents unnecessary work and event accumulation in unofficial or community builds, and makes the code more efficient and robust. Additionally, the platform info object is now cached for reuse, reducing redundant object creation.
Telemetry event gating and efficiency:
CredentialsConfigured()) before proceeding, ensuring no telemetry data is collected or sent in unofficial/community builds or when the user has opted out. This applies to initialization, event enqueuing, event flushing, and bundle event tracking (TelemetryHandler.cs).Performance improvement:
TelemetryPlatformInfoobject is now constructed once and cached for reuse across all telemetry events, avoiding redundant allocations and improving performance (TelemetryHandler.cs).