Skip to content

[WinUI] Add HyperlinkButton styling - #682

Merged
Anna Malchow-Perryman (apman) merged 3 commits into
masterfrom
agents/winui-hyperlinkbutton-styling
Oct 5, 2026
Merged

Anna Malchow-Perryman (apman) merged 3 commits into
masterfrom
agents/winui-hyperlinkbutton-styling

Conversation

@apman

@apman Anna Malchow-Perryman (apman) commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add an isolated WinUI HyperlinkButton theme with accent text, transparent borders, and subtle hover/pressed fills for Light and Dark.
  • Match WinUI's non-underlined text, preserve access keys and content templates, and keep visited links visually consistent.
  • Wire the theme into the resource index, document behavior, and mark Mica styled and classic identical to Mica following user sign-off.

Validation

  • Targeted HyperlinkButton and page catalog tests: 24 passed (also builds the theme and SampleApp).
  • Regression coverage checks undecorated string/TextBlock content in Light/Dark across normal, hover, pressed, disabled, and visited states.
  • git diff --check passes.

Reviewer notes

  • No Mica-specific overrides are required for this control.
  • Local SampleApp startup preferences are deliberately excluded from this PR.
  • No automated CI checks are expected in this repository (workflows are manual).

Posted by Copilot SDK in VS Code (agent), on behalf of Anna Malchow-Perryman (@apman).

Use WinUI accent text and subtle interaction fills without an underline.
Add light/dark state coverage and document visited-link behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 3, 2026 04:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation follows official WinUI resources, preserves expected content behavior, and includes targeted regression coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Adds an isolated WinUI-style HyperlinkButton theme using official WinUI resources and interaction states.

Changes:

  • Adds Light/Dark resources and the control theme.
  • Adds headless regression coverage and documentation.
  • Registers the theme and marks catalog variants in progress.
File Description
WinUiHyperlinkButtonTests.cs Tests undecorated content across states and themes.
README.md Documents WinUI HyperlinkButton behavior.
HyperlinkButton.axaml Defines the isolated control theme.
_index.axaml Registers the control resources.
ThemeResources.axaml Adds official WinUI state resources.
page-catalog.jsonc Marks Classic and Mica styling in progress.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

randy-but-a-ro[bot]
randy-but-a-ro Bot previously approved these changes Oct 3, 2026

@randy-but-a-ro randy-but-a-ro Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉

Integration Details
{
	"deliveryId": "14dafc40-bee5-11f1-8e0a-ab78039429aa",
	"headSha": "2550da51a7506a9457076fb46de46cb719923d88",
	"reviewer": "copilot-pull-request-reviewer[bot]"
}

Mark Mica styled and classic identical to Mica following visual sign-off.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Required Windows WinUiMica visual baselines are missing.

Review effort: Balanced
Findings: 1 High severity

Open (1)

Comment thread samples/SampleApp/PageCatalog/page-catalog.jsonc
Publish canonical Windows Mica Light and Dark screenshots for the styled page.
Verify normal regression comparisons and classic/Mica pixel equality.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 5, 2026 17:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The enabled WinUiMica visual tests need regenerated Light and Dark canonical baselines.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@randy-but-a-ro randy-but-a-ro Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉

Integration Details
{
	"deliveryId": "23a3b0d0-c0e5-11f1-9561-d6ccfaba1ad4",
	"headSha": "986dd083a87120f5e248d2d11236cc5f13384376",
	"reviewer": "copilot-pull-request-reviewer[bot]"
}

@apman
Anna Malchow-Perryman (apman) merged commit 1779b8c into master Oct 5, 2026
1 check passed
@apman
Anna Malchow-Perryman (apman) deleted the agents/winui-hyperlinkbutton-styling branch October 5, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants