Repository navigation
[Tests] Remove passing render-comparison diffs - #685
Merged
Anna Malchow-Perryman (apman) merged 1 commit intoOct 7, 2026
Merged
Anna Malchow-Perryman (apman) merged 1 commit into
Anna Malchow-Perryman (apman) merged 1 commit into
Conversation
Delete the render-equality test's expected diff output after its assertions pass, so Test-Diffs remains focused on failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Anna Malchow-Perryman (apman)
October 7, 2026 17:29
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Cleanup occurs only after all assertions pass, preserving diagnostic artifacts for failures.
0 open findings
What changed in this PR
Cleans up expected render-comparison diff artifacts after successful assertions while retaining them on failure.
Changes:
- Reuses a named comparison output folder.
- Deletes successful comparison diffs and empty parent directories.
| File | Description |
|---|---|
tests/Devolutions.AvaloniaControls.VisualTests/VisualRegressionTests.cs |
Adds post-assertion artifact cleanup. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![randy-but-a-ro[bot]](https://avatars.githubusercontent.com/in/113084?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 Pull request was approved automatically: the AI review is complete and all its review threads are resolved. 🎉
Integration Details
{
"deliveryId": "c050c630-c274-11f1-99c5-28a1cfd771b8",
"headSha": "bec619fc17ec136bd94e7a2d22efaf4e8cfad3e0",
"reviewer": "copilot-pull-request-reviewer[bot]"
}
Anna Malchow-Perryman (apman)
deleted the
agents/render-equality-check-directory-query
branch
October 7, 2026 17:45
Anna Malchow-Perryman (apman)
added a commit
that referenced
this pull request
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not yet fix the current test failure issues, but prevents date/time folders to appear in
Test-Diffsfor test runs where nothing failed, removing a source of additional confusion when trouble-shooting. (AMP)Summary
MacClassic-vs-DevExpressdiff folder after render-equality assertions pass.(this check between deliberately different pages is done to confirm that diff detection is working)
Validation
dotnet test tests/Devolutions.AvaloniaControls.VisualTests/Devolutions.AvaloniaControls.VisualTests.csproj --filter FullyQualifiedName~RenderEqualityCheck(2 passed)dotnet build avalonia-extensions.sln(succeeded; existing warnings remain)Posted by Copilot CLI (agent), on behalf of Anna Malchow-Perryman (@apman).