feat(agent,agent-installer): add policy consent helper - #1982
Benoît Cortier (CBenoit) wants to merge 25 commits into
Conversation
|
Implementation notes:
Note Human-tuned, LLM-assisted content. |
There was a problem hiding this comment.
🟡 Changes recommended
Version parsing and cancellation handling can reject valid callers or return incorrect protocol outcomes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds an elevated Agent policy-consent helper that authenticates UniGetUI and the Agent broker before forwarding policy updates.
Changes:
- Adds the NativeAOT consent helper, protocol, authentication, and tests.
- Restricts broker policy writes to the installed helper.
- Packages, signs, registers, and tests the helper in CI.
File summaries
| File | Description |
|---|---|
package/AgentWindowsManaged/Resources/Includes.cs |
Shares helper discovery constants. |
package/AgentWindowsManaged/Program.cs |
Installs and registers the helper. |
package/AgentWindowsManaged/DevolutionsAgent.csproj |
Links the shared contract. |
package/AgentWindowsManaged.Tests/PackageBrokerInstallerTests.cs |
Tests registry discovery. |
package/AgentPolicyConsent/Protocol.cs |
Defines helper framing and validation. |
package/AgentPolicyConsent/Program.cs |
Implements the helper workflow. |
package/AgentPolicyConsent/PolicyConsentContract.cs |
Defines identity and signer constants. |
package/AgentPolicyConsent/PeerTrust.cs |
Authenticates UI and broker processes. |
package/AgentPolicyConsent/DevolutionsAgentPolicyConsent.csproj |
Configures the NativeAOT executable. |
package/AgentPolicyConsent/BrokerClient.cs |
Forwards policy updates to the broker. |
package/AgentPolicyConsent/app.manifest |
Requires administrator elevation. |
package/AgentPolicyConsent.Tests/ProtocolTests.cs |
Tests protocol and trust behavior. |
package/AgentPolicyConsent.Tests/DevolutionsAgentPolicyConsent.Tests.csproj |
Configures helper tests. |
crates/now-package-broker/src/server/mod.rs |
Applies helper-specific write authentication. |
crates/now-package-broker/src/auth.rs |
Validates the installed helper identity. |
ci/package-agent-windows.ps1 |
Adds the helper to MSI packaging. |
.github/workflows/package.yml |
Signs and repackages the helper. |
.github/workflows/ci.yml |
Builds and tests the helper. |
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🔵 Needs a closer look
Helper credential validation does not conform to the canonical policy API character restrictions.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
package/AgentPolicyConsent/Protocol.cs:71
- These fields are policy-store credentials, but
IsCredentialaccepts every printable ASCII character after the first one. The canonical policy API restricts store tokens and validation receipts to[A-Za-z0-9._~:-](now-librariesmanagement.rs,PolicyStoreToken/PolicyValidationReceipt), so values containing spaces, quotes, slashes, etc. pass this protocol boundary and are only rejected later by the broker. Apply the canonical character rule here (and to returned store tokens) so malformed helper requests fail as protocol errors rather than entering the privileged write path.
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
Security-critical native authentication, elevation, protocol, and multi-architecture packaging changes warrant final human review.
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Balanced
3867fa3 to
3cce637
Compare
67a6419 to
a262d4b
Compare
a262d4b to
c5d59c2
Compare
c5d59c2 to
d2f50f3
Compare
d2f50f3 to
c1f0a22
Compare
ff4031b to
8c553f5
Compare
4c39cb0 to
c13d2a1
Compare
5eb089e to
a9395f5
Compare
Install one protected NativeAOT helper that authenticates retained UniGetUI and Agent process identities before forwarding bounded policy replacement requests. Preserve protocol 2.0 conflict and uncertainty semantics while integrating transactional discovery, signing, and packaging. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Require fresh whole-chain WinTrust revocation status before authorizing the UniGetUI parent or Agent broker. Bound broker trust retrieval to the existing exchange timeout and reject all pre-dispatch authentication failures. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Authenticate the connected Agent through its retained mapped image and an allowed Devolutions signer before sending policy data. Pin the protected installation directory chain against reparse and untrusted-writer replacement, including custom install locations, and record the evidence behind both UniGetUI signer pins. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve timeout responses during broker authentication, accept prerelease UniGetUI versions, and suppress the helper console window. Mark ARM64 discovery registry components as 64-bit so WiX can package them beneath ProgramFiles64Folder. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Apply the canonical policy API safe-ASCII character set to helper credentials before a privileged request is dispatched. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Accept only current-signed UniGetUI hosts from version 2026.2.7. Remove transition signer discovery while retaining protected helper authorization and ARM64 installer coverage. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Publish the configured broker pipe through the protected helper discovery key so consent writes work with custom local pipe names. Reject malformed discovery and oversized requests before dispatch. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document the required NativeAOT consent helper publish and packaging argument for local Agent MSI builds. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reject remote-provider parent images before retaining them for policy consent. Document every required local Agent package artifact argument. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Resolve the retained UniGetUI image path before trusting its local volume. Keep already-correct package inputs absolute while the MSI build changes directories. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the bounded broker connection lifetime aligned with the consent helper's two-minute policy replacement exchange. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep ordinary pipe capture and requests bounded to 30 seconds. Allow the two-minute exchange only after the exact consent helper is authorized. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep unauthenticated and ordinary pipe connections at 30 seconds. Extend only a successfully authorized consent-helper policy write to the two-minute exchange limit. Issue: #1963 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Retire only verified protected probe remnants after an interrupted capability check, and require retained Agent ancestor handles to remain expected directories. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use Unicode-aware literal matching for source names so a policy deny uses the same case semantics as PowerShell repository lookup. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Normalize source names before ordinal matching so policy evaluation uses the same canonical repository identity as PowerShell. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reject source spellings containing default-ignorable characters before PowerShell can resolve them to a different policy identity. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reject default-ignorable source spellings before policy evaluation and command construction can disagree. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Carry the ordinary pipe deadline through client capture and serving so unauthenticated clients cannot reserve a connection slot twice as long. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reject noncanonical source spellings before policy matching so PowerShell repository trimming cannot bypass a source-specific rule. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Apply PowerShell source canonicalization only to PowerShell so other package managers retain their own source identity semantics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reject policy source spellings that cannot safely match package requests before they can create unusable source-specific rules. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Exercise ambiguous SourceNames with a valid PowerShell rule so the regression protects the shared policy-validation predicate. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Publish consent-helper discovery and configured broker-pipe values to the 32-bit registry view so supported x86 consumers find the protected helper. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove the obsolete warning acknowledgement field so helper replacement requests match the released policy API after the parent rebase. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
c13d2a1 to
1145f0c
Compare
Adds an Agent-installed consent helper that lets supported UniGetUI installations request protected policy updates with explicit elevation consent.
The helper authenticates the running UniGetUI and Agent images, preserves policy validation and conflict semantics, and is installed and discovered through the Agent MSI for both default per-user and all-users UniGetUI deployments.
Issue: #1963