fix(picky): anchor Authenticode CTL check on the root certificate - #533
Draft
Mathieu Morrissette (mmorrissette-devolutions) wants to merge 2 commits into
Draft
Mathieu Morrissette (mmorrissette-devolutions) wants to merge 2 commits into
Mathieu Morrissette (mmorrissette-devolutions) wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Match the CTL entry on the SHA-1 thumbprint of the root certificate, after verifying the chain up to it, instead of the issuer name hash. Add `trusted_roots()` to provide roots not embedded in the signature, and prefer a CTL-listed root among those whose key signed the chain.
Mathieu Morrissette (mmorrissette-devolutions)
force-pushed
the
fix/authenticode-ctl-root-thumbprint
branch
from
September 28, 2026 16:21
ce83e63 to
0c0f5dd
Compare
Author
|
Codex (@codex) review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the CTL entry on the SHA-1 thumbprint of the root certificate, after verifying the chain up to it, instead of the issuer name hash. Roots not embedded in the signature can be provided with
trusted_roots().Breaking: signatures that don't embed their root (signtool's default) now fail with
RootCertificateUnavailableunless the root is provided withtrusted_roots(); follow-ups could verify the CTL's own PKCS#7 signature and add a root provider that fetches missing roots from Windows Update by thumbprint.