fix(picky): don't panic on RFC 3161 timestamp fallback - #534
Open
Mathieu Morrissette (mmorrissette-devolutions) wants to merge 1 commit into
Open
Mathieu Morrissette (mmorrissette-devolutions) wants to merge 1 commit into
Mathieu Morrissette (mmorrissette-devolutions) wants to merge 1 commit into
Conversation
Mathieu Morrissette (mmorrissette-devolutions)
force-pushed
the
fix/authenticode-timestamp-borrow-panic
branch
2 times, most recently
from
September 28, 2026 17:13
30b5388 to
eca20da
Compare
h_verify_signing_certificate held a mutable borrow of the validator state while the MsCounterSign fallback borrowed it again, so verifying an expired, timestamped signature with the ctl feature panicked with "already mutably borrowed". The borrow is only read, so make it shared.
Mathieu Morrissette (mmorrissette-devolutions)
force-pushed
the
fix/authenticode-timestamp-borrow-panic
branch
from
September 28, 2026 17:17
eca20da to
9a22075
Compare
Mathieu Morrissette (mmorrissette-devolutions)
requested a review
from Benoît Cortier (CBenoit)
September 28, 2026 17:24
Mathieu Morrissette (mmorrissette-devolutions)
marked this pull request as ready for review
September 28, 2026 17:24
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h_verify_signing_certificateholds a mutable borrow of the validator state for its whole body, and theMsCounterSignfallback (expired signing certificate, RFC 3161 timestamp) borrows it again to read the CTL. With thectlfeature, verifying such a signature panics withalready mutably borrowed: BorrowError, whether or not a CTL is set. The borrow is only read, so it's now shared.The new test verifies the psdiag signature after its signing certificate expired; it panics without the fix. The signature moves from
full_validation_authenticode_signature_with_well_known_catopicky-test-dataso both tests share it.