docs: remove duplicate README filtering paragraph - #318
Conversation
- keep the current service filtering coverage list
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This PR successfully removes a duplicate paragraph about service/context filtering from the README while retaining the more complete and current version. The change improves documentation clarity without affecting functionality. No issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
YoungJinJung
left a comment
There was a problem hiding this comment.
The retained coverage list drops CloudFormation stacks, but current main still implements the shared / filter for that screen (internal/app/screen_cloudformation.go and the README key-binding table). Please keep CloudFormation stacks in the surviving paragraph while removing the duplicate.
- keep the surviving README coverage list aligned with the TUI
|
Applied the review request in 37ad4a7 by restoring CloudFormation stacks to the surviving filtering coverage list. Confirmed the screen uses the shared filter, and reran |
|
Duplicate-checked against my #323 (now closed in favour of this one) — the dedupe and the union of the two coverage lists here are correct. One optional addition while this paragraph is being touched: four screens have working Verified against the code rather than inferred — each has both an
Suggested placements that keep the existing grouping:
Entirely optional — checklist item 2 ("keep the surviving service coverage list aligned with the current TUI screens") is what prompted it. Fine to land this as-is and treat the four as a follow-up. |
- include the four verified shared-filter screens
|
Applied the reviewer follow-up in 8ad2731: added security groups, CloudWatch alarms, CloudTrail events, and KMS keys to the surviving filtering coverage list after verifying each shared-filter code path. |
|
/q review |
There was a problem hiding this comment.
Documentation cleanup successfully removes the duplicate filtering paragraph while preserving the authoritative version with complete service coverage. The change is straightforward and correct.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
youngjinjung-linq
left a comment
There was a problem hiding this comment.
Verified the complete README-only diff against the current shared-filter call sites. The duplicate is removed, the retained coverage list reflects the implemented screens, is the merge base, and all checks pass.
|
Merge blocker: |
Summary
Remove the stale duplicate service/context filtering paragraph from README.md while retaining the authoritative paragraph with the current filtering coverage.
Related Issues
Closes #317
Validation
make testmake buildgit diff --check origin/main...HEADChecklist
docs/branch-naming-harness.mddocs/documentation-harness.md)docs/pages reviewed; no additional updates required