Skip to content

add wait flag to context put operations in test#386

Merged
shihab-dls merged 1 commit into
mainfrom
fix_tests
Jun 16, 2026
Merged

add wait flag to context put operations in test#386
shihab-dls merged 1 commit into
mainfrom
fix_tests

Conversation

@shihab-dls

@shihab-dls shihab-dls commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

PR #385 passed CI, but this seems to have been a flaky pass, and is now failing main; this PR adds wait=True to test_softioc_system, which was left out of the merged PR.

Summary by CodeRabbit

  • Tests
    • Strengthened soft IOC system test robustness by implementing synchronous write operations with explicit wait directives to ensure proper test sequencing
    • Extended validation coverage to verify that readback field aliasing behaves correctly and consistently across all related system components

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3a881d12-925a-4e30-9e34-7e06df6924c6

📥 Commits

Reviewing files that changed from the base of the PR and between 508d8af and 3effde9.

📒 Files selected for processing (1)
  • tests/transports/epics/ca/test_softioc_system.py

📝 Walkthrough

Walkthrough

test_ioc adds wait=True to both ctxt.put calls for :B and :AliasB, making writes synchronous. After updating :AliasB to 20, the test now also asserts that :B_RBV equals :AliasB_RBV and that both equal 20.

Changes

Alias RBV Assertion and Synchronous Writes

Layer / File(s) Summary
Synchronous writes and aliased RBV assertions
tests/transports/epics/ca/test_softioc_system.py
Both ctxt.put calls for :B and :AliasB now pass wait=True, and an additional assertion verifies that :B_RBV and :AliasB_RBV are aliased and reflect the written value of 20.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through channels with care,
Waiting for writes to settle in the air.
:B_RBV and :AliasB_RBV stand tall,
Both equal twenty — aliased, one and all! 🐇
The readback is right, the test will not stall!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: adding wait flags to context put operations in a test file.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (ebb7a8e) to head (3effde9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files          72       72           
  Lines        2892     2892           
=======================================
  Hits         2639     2639           
  Misses        253      253           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shihab-dls shihab-dls requested review from coretl and gilesknap June 16, 2026 09:13
@shihab-dls shihab-dls merged commit 8c54354 into main Jun 16, 2026
11 checks passed
@shihab-dls shihab-dls deleted the fix_tests branch June 16, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants